[Lldb-commits] [PATCH] D131663: [LLDB][ARM] Extend testing for vpush emulation

[David Spickett via Phabricator via lldb-commits]

DavidSpickett created this revision.
Herald added a subscriber: kristof.beyls.
Herald added a project: All.
DavidSpickett requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.

https://reviews.llvm.org/D131658 found a bug in
ReadPseudoRegisterValue which would mean we read out
of bounds if the s register number was high enough.

This adds a memory check to vpush-1-thumb, which
should have been doing that anyway. Then copies that
test and uses the last 4 s registers instead.

Without the mentioned fix we see random values in
the final memory, with the fix it passes.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D131663

Files:
  lldb/test/API/arm/emulation/new-test-files/test-vpush-1-high-sregs-thumb.dat
  lldb/test/API/arm/emulation/new-test-files/test-vpush-1-thumb.dat

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D131663.451788.patch
Type: text/x-patch
Size: 2512 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20220811/f5e2e0c7/attachment.bin>