[Lldb-commits] [PATCH] D131615: [LLDB][NFC] Reliability fixes for IOHandlerCursesGUI

[Slava Gurevich via Phabricator via lldb-commits]

fixathon added inline comments.


================
Comment at: lldb/source/Core/IOHandlerCursesGUI.cpp:391-394
+  uint32_t GetMaxX() const { return getmaxx(m_window); }
+  uint32_t GetMaxY() const { return getmaxy(m_window); }
+  uint32_t GetWidth() const { return GetMaxX(); }
+  uint32_t GetHeight() const { return GetMaxY(); }
----------------
clayborg wrote:
> the underlying curses functions return "int". Were there places where people were comparing them to unsigned?
A function HorizontalLine() at line 2582 requires non-negative input. Good point about the underlying function possibly returning a negative still.


================
Comment at: lldb/source/Core/IOHandlerCursesGUI.cpp:2582
     surface.MoveCursor(0, 1);
     surface.HorizontalLine(surface.GetWidth());
   }
----------------
Here we have HorizontalLine() function that requires non-negative input


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131615/new/

https://reviews.llvm.org/D131615