[Lldb-commits] [PATCH] D131531: [lldb] Allow DataFileCache to be constructed with a different policy

Jonas Devlieghere via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed Aug 10 10:47:10 PDT 2022


JDevlieghere added inline comments.


================
Comment at: lldb/include/lldb/Core/DataFileCache.h:82
 
 private:
+  /// Gets the default LLDB index cache policy, which is s
----------------
It's a little weird that `GetLLDBIndexCachePolicy` would be private,  if only from a documentation point of view so that you can refer to it in the constructor. 


================
Comment at: lldb/include/lldb/Core/DataFileCache.h:83
 private:
+  /// Gets the default LLDB index cache policy, which is s
+  static llvm::CachePruningPolicy GetLLDBIndexCachePolicy();
----------------
Comment is incomplete


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131531/new/

https://reviews.llvm.org/D131531



More information about the lldb-commits mailing list