[Lldb-commits] [PATCH] D130342: [LLDB][RISCV] Add riscv register stuff

[David Spickett via Phabricator via lldb-commits]

DavidSpickett accepted this revision.
DavidSpickett added a comment.
This revision is now accepted and ready to land.

> we can add them back if required in the future.

Sounds good to me. Certainly SVE for Arm required a bunch of changes, a lot easier to do it later.

This LGTM, but:

  [LLDB][RISCV] Add riscv register stuff

Can we have something more specific than "stuff" :) (not that I don't use vague terms sometimes) "Add RISCV register information" ?

Just thinking that if I was a riscv user and I was looking at lldb logs I'd want to know "what did this commit enable", what works now that didn't before? And "stuff" doesn't help me there. "information" at least doesn't commit to enabling any new functionality.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130342/new/

https://reviews.llvm.org/D130342