[Lldb-commits] [PATCH] D131539: [lldb] Make sure all Python API tests are marked as NO_DEBUG_INFO_TESTCASE

Jonas Devlieghere via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Aug 9 21:21:19 PDT 2022


JDevlieghere added a comment.

In D131539#3711488 <https://reviews.llvm.org/D131539#3711488>, @kastiglione wrote:

> this diff has made me wonder: should we have a `NoDebugInfoTestCase` that can be used by any test, and would replace assigning to `NO_DEBUG_INFO_TESTCASE`?

I was wondering the same thing. I decided against it because we already have `NO_DEBUG_INFO_TESTCASE` (test level) and `@no_debug_info_test` (function level) and I didn't want to add yet another option. Additionally, there's a few other patters that are common for the Python API tests (e.g. the `self.source` and `self.line`) that could be moved up into the base class in a follow up patch.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131539/new/

https://reviews.llvm.org/D131539



More information about the lldb-commits mailing list