[Lldb-commits] [PATCH] D131085: [lldb/crashlog] Refactor the CrashLogParser logic

[Dave Lee via Phabricator via lldb-commits]

kastiglione accepted this revision.
kastiglione added a comment.
This revision is now accepted and ready to land.

thanks for having patience with us reviewers, lgtm with one comment about python versions



================
Comment at: lldb/examples/python/crashlog.py:421
+    def __new__(cls, debugger, path, verbose):
+        if data := JSONCrashLogParser.is_valid_json(path):
+            self = object.__new__(JSONCrashLogParser)
----------------
the walrus operator (`:=`) is python 3.8 or newer, just want to make sure we don't expect this code to run in 3.6 or other earlier versions


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131085/new/

https://reviews.llvm.org/D131085