[Lldb-commits] [PATCH] D131159: [lldb] Use WSAEventSelect for MainLoop polling on windows

[Martin Storsjö via Phabricator via lldb-commits]

mstorsjo added a comment.

In D131159#3709965 <https://reviews.llvm.org/D131159#3709965>, @labath wrote:

>> Can @alvinhochun take the patch for a spin? I think you've got more realistic usecases of lldb to try it out in. (Do you want me to make a build with the patch for you to try out?) @labath What's the best way to exercise this code in actual use of lldb?
>
> I would appreciate that. I have tried to build it and run the test suite, but I didn't have a clean baseline, so I can't really say whether it works for everything. The main user of this code is the gdb-remote communication code, so debugging something via lldb-server (or running the lldb-server test suite) should be a good indicator of whether it works.

I presume this is covered by running `ninja check-lldb`, or should I flip the switch to prefer lldb-server on Windows before doing that? (I guess I can do both.) I've got an environment where `check-lldb` mostly passes, I can check that it doesn't regress it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131159/new/

https://reviews.llvm.org/D131159