[Lldb-commits] [lldb] 0c86fbb - The memory region tests have been consistently timing on the ASAN

[Jim Ingham via lldb-commits]

Author: Jim Ingham
Date: 2022-08-09T12:52:18-07:00
New Revision: 0c86fbb557a63d2e9cc2e1a82feb38fe11ecbcdd

URL: https://github.com/llvm/llvm-project/commit/0c86fbb557a63d2e9cc2e1a82feb38fe11ecbcdd
DIFF: https://github.com/llvm/llvm-project/commit/0c86fbb557a63d2e9cc2e1a82feb38fe11ecbcdd.diff

LOG: The memory region tests have been consistently timing on the ASAN
bot.  This happens because they are building a long result into
a Python string, and the asan checker is making that very slow.

The last two tests here are both slow, but the 'test_command' is the
really slow one.  I'm going to start disabling just that one and see
if that gets the ASAN bots clean.

Added: 
    

Modified: 
    lldb/test/API/functionalities/memory-region/TestMemoryRegion.py

Removed: 
    


################################################################################
diff  --git a/lldb/test/API/functionalities/memory-region/TestMemoryRegion.py b/lldb/test/API/functionalities/memory-region/TestMemoryRegion.py
index 3ea4a75ec9b9c..50d64de5b7543 100644
--- a/lldb/test/API/functionalities/memory-region/TestMemoryRegion.py
+++ b/lldb/test/API/functionalities/memory-region/TestMemoryRegion.py
@@ -37,6 +37,11 @@ def setup_program(self):
 
         self.runCmd("run", RUN_SUCCEEDED)
 
+    # This test builds a large result string in such a way that when run
+    # under ASAN the test always times out.  Most of the time is in the asan
+    # checker under PyUnicode_Append.
+    # This seems to be a worst-case scenario for ASAN performance.
+    @skipIfAsan
     def test_command(self):
         self.setup_program()
 
@@ -119,4 +124,4 @@ def test_no_overlapping_regions(self):
                     "Unexpected overlapping memory region found.")
 
                 previous_base = region_base
-                previous_end = region_end
\ No newline at end of file
+                previous_end = region_end