[Lldb-commits] [PATCH] D131459: Move FormattersMatchCandidate flags to a struct.

[Pavel Labath via Phabricator via lldb-commits]

labath accepted this revision.
labath added inline comments.


================
Comment at: lldb/include/lldb/DataFormatters/FormatClasses.h:50
+  struct Flags {
+    bool m_stripped_pointer = false;
+    bool m_stripped_reference = false;
----------------
We don't generally use the `m_` prefix on structs. This struct is a bit of an edge case, as it has non-trivial member functions -- so one could consider making it a class (members private and public accessors) -- but if you don't want to do that (which is fine by me), then I think it'd be better to remove the prefixes.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131459/new/

https://reviews.llvm.org/D131459