[Lldb-commits] [PATCH] D131304: [lldb] Remove uses of six module (NFC)

Tue Aug 9 01:50:04 PDT 2022

DavidSpickett added inline comments.

================
Comment at: lldb/bindings/python/CMakeLists.txt:63-68
-  if(NOT LLDB_USE_SYSTEM_SIX)
-    add_custom_command(TARGET ${swig_target} POST_BUILD VERBATIM
-      COMMAND ${CMAKE_COMMAND} -E copy
-        "${LLDB_SOURCE_DIR}/third_party/Python/module/six/six.py"
-        "${lldb_python_target_dir}/../six.py")
-  endif()
----------------
kastiglione wrote:
> @DavidSpickett I removed `LLDB_USE_SYSTEM_SIX` but left the code that copies vendored copy of six.py. Is this what you had in mind? My thinking is there might be lldb scripts that use `six`, and I don't want the removal of internal use of `six` to be a breaking change downstream, not yet anyway.
I hadn't considered user scripts good point.

If you were using this option, you'd now get a warning from cmake that it's value was unused. Would it make more sense to have a proper deprecation warning and remove it and the copy of six at some later point?

Please land this change minus the `LLDB_USE_SYSTEM_SIX` stuff though. I don't want to block the rest on this.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131304/new/

https://reviews.llvm.org/D131304