[Lldb-commits] [lldb] 06ff46d - [LLDB][NFC] Fix suspicious bitwise expression in PrintBTEntry()

[Slava Gurevich via lldb-commits]

Author: Slava Gurevich
Date: 2022-08-08T09:04:22-07:00
New Revision: 06ff46d2d77feba285e672e2da42039c88dc965a

URL: https://github.com/llvm/llvm-project/commit/06ff46d2d77feba285e672e2da42039c88dc965a
DIFF: https://github.com/llvm/llvm-project/commit/06ff46d2d77feba285e672e2da42039c88dc965a.diff

LOG: [LLDB][NFC] Fix suspicious bitwise expression in PrintBTEntry()

Current application of bitwise-OR to a binary mask always results in True, which seems
inconsistent with the intent of the statement, a likely typo.

Differential Revision: https://reviews.llvm.org/D131312

Added: 
    

Modified: 
    lldb/tools/intel-features/intel-mpx/cli-wrapper-mpxtable.cpp

Removed: 
    


################################################################################
diff  --git a/lldb/tools/intel-features/intel-mpx/cli-wrapper-mpxtable.cpp b/lldb/tools/intel-features/intel-mpx/cli-wrapper-mpxtable.cpp
index b19d8b7387bb..de6d50038a27 100644
--- a/lldb/tools/intel-features/intel-mpx/cli-wrapper-mpxtable.cpp
+++ b/lldb/tools/intel-features/intel-mpx/cli-wrapper-mpxtable.cpp
@@ -63,7 +63,7 @@ static void PrintBTEntry(lldb::addr_t lbound, lldb::addr_t ubound,
   const lldb::addr_t one_cmpl64 = ~((lldb::addr_t)0);
   const lldb::addr_t one_cmpl32 = ~((uint32_t)0);
 
-  if ((lbound == one_cmpl64 || one_cmpl32) && ubound == 0) {
+  if ((lbound == one_cmpl64 || lbound == one_cmpl32) && ubound == 0) {
     result.Printf("Null bounds on map: pointer value = 0x%" PRIu64 "\n", value);
   } else {
     result.Printf("    lbound = 0x%" PRIu64 ",", lbound);