[Lldb-commits] [PATCH] D131275: [lldb] Make Process and subclass constructors protected

[Michał Górny via Phabricator via lldb-commits]

mgorny added inline comments.


================
Comment at: lldb/include/lldb/Target/Process.h:478-487
+protected:
   /// Construct with a shared pointer to a target, and the Process listener.
   /// Uses the Host UnixSignalsSP by default.
   Process(lldb::TargetSP target_sp, lldb::ListenerSP listener_sp);
 
   /// Construct with a shared pointer to a target, the Process listener, and
   /// the appropriate UnixSignalsSP for the process.
----------------
labath wrote:
> Just move this to the existing protected section on line 2500 (boy is this class big). Too many sections makes it hard to find what's the visibility of something.
Will do. Wasn't sure whether this was desirable or not.


================
Comment at: lldb/unittests/Expression/DWARFExpressionTest.cpp:331
   struct MockProcess : Process {
-    using Process::Process;
+    MockProcess(lldb::TargetSP target_sp, lldb::ListenerSP listener_sp)
+        : Process(target_sp, listener_sp) {}
----------------
labath wrote:
> huh, I did not expect this to be necessary. Inherited constructors are weird...
Yes, they are. I've searched a bit and couldn't find a way to make `using` change their visibility.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131275/new/

https://reviews.llvm.org/D131275