[Lldb-commits] [lldb] b06da9c - Remove the check for eStateConnected in remote testing sessions.

[Jim Ingham via lldb-commits]

Author: Jim Ingham
Date: 2022-08-04T09:19:55-07:00
New Revision: b06da9c18390f84950e1d8f70ef2bb0efb433075

URL: https://github.com/llvm/llvm-project/commit/b06da9c18390f84950e1d8f70ef2bb0efb433075
DIFF: https://github.com/llvm/llvm-project/commit/b06da9c18390f84950e1d8f70ef2bb0efb433075.diff

LOG: Remove the check for eStateConnected in remote testing sessions.

This check is clearly incorrect, there's no way you should have an
eStateConnected event left on the queue if you've already launched
and hit a breakpoint in the program.  This check fails running remotely
on Darwin systems and on one remote Linux platform.  And if we do
find this failing somewhere, we should fix the bogus eStateConnected,
not the test.

Added: 
    

Modified: 
    lldb/test/API/functionalities/signal/TestSendSignal.py

Removed: 
    


################################################################################
diff  --git a/lldb/test/API/functionalities/signal/TestSendSignal.py b/lldb/test/API/functionalities/signal/TestSendSignal.py
index 5808ca17e566c..be74f00aa10a3 100644
--- a/lldb/test/API/functionalities/signal/TestSendSignal.py
+++ b/lldb/test/API/functionalities/signal/TestSendSignal.py
@@ -70,10 +70,6 @@ def test_with_run_command(self):
         # Now continue:
         process.Continue()
 
-        # If running remote test, there should be a connected event
-        if lldb.remote_platform:
-            self.match_state(process_listener, lldb.eStateConnected)
-
         self.match_state(process_listener, lldb.eStateRunning)
 
         # Now signal the process, and make sure it stops: