[Lldb-commits] [PATCH] D128250: [LLDB][RISCV]Add initial support for lldb-server.

Tiancheng Zhang via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed Aug 3 22:02:15 PDT 2022


tzb99 added a comment.

In D128250#3661588 <https://reviews.llvm.org/D128250#3661588>, @Emmmer wrote:

> This commit updates:
>
> - Add the pc register according to the implementation of gdb <https://github.com/riscv-collab/riscv-binutils-gdb/blob/riscv-binutils-2.38/gdb/features/riscv/64bit-cpu.c#L44>
> - Fix register type definition macros to pass register checks
>
> The NaN problem has been solved by D129750 <https://reviews.llvm.org/D129750>
>
> At this point, we can pass all LLDBUnitTest.
>
> It may be challenging to review and merge at one time for such a large patch. I would like to ask if it‘s necessary to split this patch and merge them in turn.

Hello:

Thank you so much for sharing the patch files. One thing I am still curious is what the ABISysv file you are using. Would you mind also sharing the remaining patches added for the lldb-server support?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128250/new/

https://reviews.llvm.org/D128250



More information about the lldb-commits mailing list