[Lldb-commits] [PATCH] D131032: [lldb/crashlog] Update frame regex matcher

Jonas Devlieghere via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed Aug 3 21:04:06 PDT 2022


JDevlieghere added a comment.

In D131032#3698163 <https://reviews.llvm.org/D131032#3698163>, @mib wrote:

> In D131032#3698108 <https://reviews.llvm.org/D131032#3698108>, @JDevlieghere wrote:
>
>> Can we test this by modifying an address in the existing test case?
>
> Sure but we won't be able to symbolicate that frame anymore ... do we really want to do that ?

I think that's a fair trade-off to get regression coverage.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131032/new/

https://reviews.llvm.org/D131032



More information about the lldb-commits mailing list