[Lldb-commits] [PATCH] D131086: [lldb/crashlog] Improve exception reporting for interactive mode

[Med Ismail Bennani via Phabricator via lldb-commits]

mib marked 2 inline comments as done.
mib added inline comments.


================
Comment at: lldb/source/Plugins/Process/Utility/StopInfoMachException.cpp:525-542
+  case EXC_BAD_ACCESS:
+    return "EXC_BAD_ACCESS";
+  case EXC_BAD_INSTRUCTION:
+    return "EXC_BAD_INSTRUCTION";
+  case EXC_ARITHMETIC:
+    return "EXC_ARITHMETIC";
+  case EXC_EMULATION:
----------------
JDevlieghere wrote:
> Just double checking: I assume these are always defined, even when `mach/exception.h` is not included?
no, I'm getting the following error if I don't include `mach/exception.h `

```
llvm.org/lldb/source/Plugins/Process/Utility/StopInfoMachException.cpp:525:8: error: use of undeclared identifier 'EXC_BAD_ACCESS'
  case EXC_BAD_ACCESS:
       ^
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131086/new/

https://reviews.llvm.org/D131086