[Lldb-commits] [lldb] 9ffcc85 - Revert "Revert "[lldb][modules] Disable Clang Modules in source/Host directory on macOS""

[Jonas Devlieghere via lldb-commits]

Author: Jonas Devlieghere
Date: 2022-08-03T14:39:45-07:00
New Revision: 9ffcc85fbe52b4480a82749e58b19c3ea5be5e99

URL: https://github.com/llvm/llvm-project/commit/9ffcc85fbe52b4480a82749e58b19c3ea5be5e99
DIFF: https://github.com/llvm/llvm-project/commit/9ffcc85fbe52b4480a82749e58b19c3ea5be5e99.diff

LOG: Revert "Revert "[lldb][modules] Disable Clang Modules in source/Host directory on macOS""

This reverts commit c7bd61d4a79b88dbd97028bb0a73a73b2d6aca89 because it
breaks the underlying issue is apparently not yet resolved. This only
affects the modules build.

Added: 
    

Modified: 
    lldb/source/Host/CMakeLists.txt

Removed: 
    


################################################################################
diff  --git a/lldb/source/Host/CMakeLists.txt b/lldb/source/Host/CMakeLists.txt
index 219965ff16056..64d9bb00ffab3 100644
--- a/lldb/source/Host/CMakeLists.txt
+++ b/lldb/source/Host/CMakeLists.txt
@@ -1,3 +1,11 @@
+if (APPLE AND LLVM_ENABLE_LOCAL_SUBMODULE_VISIBILITY)
+  # The arpa/inet.h header used in the files here is providing a miscompiled
+  # htonl function on macOS <= 10.15 when local submodule visibility is active.
+  # Disabling modules in this directory until this is is fixed.
+  # See rdar://problem/62886385
+  remove_module_flags()
+endif()
+
 macro(add_host_subdirectory group)
   list(APPEND HOST_SOURCES ${ARGN})
   source_group(${group} FILES ${ARGN})