[Lldb-commits] [PATCH] D131083: [lldb] Add assertStopReason helper function

[Med Ismail Bennani via Phabricator via lldb-commits]

mib accepted this revision.
mib added a comment.
This revision is now accepted and ready to land.

LGTM!



================
Comment at: lldb/packages/Python/lldbsuite/test/lldbutil.py:269-272
+    elif enum == lldb.eStopReasonInstrumentation:
+        return "instrumentation"
+    elif enum == lldb.eStopReasonProcessorTrace:
+        return "processortrace"
----------------
This is more a general comment, but I'm very annoyed at how C/C++ enums are exposed to Python ... Now every time we add a new value to the enum we need to remember to update these helper function. The comment is not related specifically to this patch but I think we can do a better job here.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131083/new/

https://reviews.llvm.org/D131083