[Lldb-commits] [PATCH] D131032: [lldb/crashlog] Update frame regex matcher

Jonas Devlieghere via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed Aug 3 11:11:40 PDT 2022


JDevlieghere added inline comments.


================
Comment at: lldb/examples/python/crashlog.py:604
+                             r'(' +version+ r')?'               # img_version
+                             r'(0x[0-9a-fA-F]{7}[0-9a-fA-F]*)'  # addr
+                             r' +(.*)'                          # offs
----------------
kastiglione wrote:
> Can it be simplified to using `{7,}`, for "7 or more"?
> 
> Ex: `r'(0x[0-9a-fA-F]{7,}`
I like this idea (and learned something new)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131032/new/

https://reviews.llvm.org/D131032



More information about the lldb-commits mailing list