[Lldb-commits] [PATCH] D131075: [lldb] [gdb-remote] Send interrupt packets from async thread

[Michał Górny via Phabricator via lldb-commits]

mgorny added a comment.
Herald added a subscriber: JDevlieghere.

In D131075#3696782 <https://reviews.llvm.org/D131075#3696782>, @labath wrote:

> Looks good. Please pay special attention to the windows bot when landing.

Thanks. Will do.



================
Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteClientBase.cpp:55-63
   OnRunPacketSent(true);
-  // The main ReadPacket loop wakes up at computed_timeout intervals, just to 
+  // The main ReadPacket loop wakes up at computed_timeout intervals, just to
   // check that the connection hasn't dropped.  When we wake up we also check
   // whether there is an interrupt request that has reached its endpoint.
-  // If we want a shorter interrupt timeout that kWakeupInterval, we need to 
+  // If we want a shorter interrupt timeout that kWakeupInterval, we need to
   // choose the shorter interval for the wake up as well.
+  std::chrono::seconds computed_timeout =
----------------
labath wrote:
> I think this could be simplified now (to avoid the intermittent wakeups), but those wakeups could be the only thing that makes windows work...
If Windows relies on this, we'll soon find out by seeing a few tests failing due to interrupts taking too long (I've seen this myself prior to adding the `InterruptRead()` call).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131075/new/

https://reviews.llvm.org/D131075