[Lldb-commits] [PATCH] D126614: [lldb] [gdb-remote] Client support for using the non-stop protocol

Wed Aug 3 06:56:07 PDT 2022

mgorny added inline comments.

================
Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteClientBase.cpp:138
+    // and then drain the notification queue
+    // TODO: issue vCont;t to ensure that all threads have actually stopped
+    // (this is not needed for LLGS but for gdbserver)
----------------
labath wrote:
> Could we just send vCont;t to begin with? (I know this was discussed already, but that was before we switched to the new interruption mechanism)
I'm sorry but I don't understand what you're asking about. The `vCont;t` part is split into D129554 since it involves some finicky logic because we can't predict if we're going to get any notifications or not.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126614/new/

https://reviews.llvm.org/D126614