[Lldb-commits] [PATCH] D130803: [lldb] Allow SymbolTable regex search functions to match mangled name

Wed Aug 3 03:14:37 PDT 2022

labath accepted this revision.
labath added a comment.

In D130803#3691363 <https://reviews.llvm.org/D130803#3691363>, @augusto2112 wrote:

> In D130803#3690754 <https://reviews.llvm.org/D130803#3690754>, @labath wrote:
>
>> Who sets this flag? How do you intend to use it?
>
> I need this change downstream to search for certain swift mangled names by querying `Module::FindSymbolsMatchingRegExAndType`. It seemed general enough that we might want this upstream.

That's ok. The reason I was asking was because it affects the ways in which one can test that.

================
Comment at: lldb/test/Shell/Symtab/Inputs/t.yaml:1
+--- !mach-o
+FileHeader:
----------------
Use a more descriptive name for the file.

I'd also consider using an elf file for this test, simply because their yaml form is much more concise (and you can strip out pretty much everything except the symtab, and use an unlinked .o file as the template, and still have it work).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130803/new/

https://reviews.llvm.org/D130803