[Lldb-commits] [PATCH] D131013: [LLDB][NFC] Fix incorrect return status Some functions always return 'false' for both success and fail return paths.
Slava Gurevich via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Tue Aug 2 15:56:45 PDT 2022
This revision was automatically updated to reflect the committed changes.
Closed by commit rG4502e3531f62: [LLDB][NFC] Fix incorrect return status Some functions always return 'false'… (authored by fixathon).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D131013/new/
https://reviews.llvm.org/D131013
Files:
lldb/source/Plugins/Language/ObjC/NSArray.cpp
lldb/source/Plugins/Language/ObjC/NSDictionary.cpp
lldb/source/Plugins/Language/ObjC/NSSet.cpp
Index: lldb/source/Plugins/Language/ObjC/NSSet.cpp
===================================================================
--- lldb/source/Plugins/Language/ObjC/NSSet.cpp
+++ lldb/source/Plugins/Language/ObjC/NSSet.cpp
@@ -461,7 +461,7 @@
if (error.Fail())
return false;
m_data_ptr = data_location + m_ptr_size;
- return false;
+ return true;
}
bool lldb_private::formatters::NSSetISyntheticFrontEnd::MightHaveChildren() {
@@ -735,9 +735,7 @@
process_sp->ReadMemory(data_location, m_data_64, sizeof(D64),
error);
}
- if (error.Fail())
- return false;
- return false;
+ return error.Success();
}
template <typename D32, typename D64>
Index: lldb/source/Plugins/Language/ObjC/NSDictionary.cpp
===================================================================
--- lldb/source/Plugins/Language/ObjC/NSDictionary.cpp
+++ lldb/source/Plugins/Language/ObjC/NSDictionary.cpp
@@ -1121,9 +1121,8 @@
process_sp->ReadMemory(data_location, m_data_64, sizeof(D64),
error);
}
- if (error.Fail())
- return false;
- return true;
+
+ return error.Success();
}
template <typename D32, typename D64>
@@ -1284,9 +1283,8 @@
process_sp->ReadMemory(data_location, m_data_64, sizeof(DataDescriptor_64),
error);
}
- if (error.Fail())
- return false;
- return false;
+
+ return error.Success();
}
bool
Index: lldb/source/Plugins/Language/ObjC/NSArray.cpp
===================================================================
--- lldb/source/Plugins/Language/ObjC/NSArray.cpp
+++ lldb/source/Plugins/Language/ObjC/NSArray.cpp
@@ -532,9 +532,8 @@
process_sp->ReadMemory(data_location, m_data_64, sizeof(D64),
error);
}
- if (error.Fail())
- return false;
- return false;
+
+ return error.Success();
}
bool
@@ -675,9 +674,8 @@
process_sp->ReadMemory(data_location, m_data_64, sizeof(D64),
error);
}
- if (error.Fail())
- return false;
- return false;
+
+ return error.Success();
}
template <typename D32, typename D64, bool Inline>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D131013.449468.patch
Type: text/x-patch
Size: 2145 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20220802/94dd9856/attachment-0001.bin>
More information about the lldb-commits
mailing list