[Lldb-commits] [PATCH] D131005: [LLDB] Add SBInstruction::GetControlFlowKind()

[walter erquinigo via Phabricator via lldb-commits]

wallace accepted this revision.
wallace added a comment.
This revision is now accepted and ready to land.

great!



================
Comment at: lldb/source/API/SBInstruction.cpp:176
+    if (target_sp) {
+      lock = std::unique_lock<std::recursive_mutex>(target_sp->GetAPIMutex());
+
----------------
this might be potentially expensive. If this slows traversals down, eventually we can create an unsafe version of this method that avoids mutexes but is faster.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131005/new/

https://reviews.llvm.org/D131005