[Lldb-commits] [PATCH] D62764: Detect x86 mid-function epilogues that end in a jump

[Jason Molenda via Phabricator via lldb-commits]

jasonmolenda added inline comments.


================
Comment at: lldb/trunk/source/Plugins/UnwindAssembly/x86/x86AssemblyInspectionEngine.cpp:707-713
+  if (second_byte_sans_reg == 0x24)
+    return true;
+
+  // use SIB byte
+  // ff 24 fe  jmpq   *(%rsi,%rdi,8)
+  if (second_byte_sans_reg == 0x24)
+    return true;
----------------
fixathon wrote:
> jasonmolenda wrote:
> > fixathon wrote:
> > > This looks like duplicate code
> > At least it does the same thing in both of them!  :) 
> It does indeed, but the comments above the code are different for the 2 identical blocks of code. Do you want to fix it then? :)
:) I see there's a comment intended for this first entry a dozen lines earlier in the source file, it's probably gotten confusing over time & edits.  yah I'll fix it, thanks for catching it.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62764/new/

https://reviews.llvm.org/D62764