[Lldb-commits] [PATCH] D130930: [trace] Add SBTraceCursor bindings

[Jonas Devlieghere via Phabricator via lldb-commits]

JDevlieghere added inline comments.


================
Comment at: lldb/include/lldb/API/SBTraceCursor.h:1-2
+//===-- SBTraceCursor.h -----------------------------------------------*- C++
+//-*-===//
+//
----------------
Broken ASCII art


================
Comment at: lldb/source/API/SBTrace.cpp:47
+SBTraceCursor SBTrace::CreateNewCursor(SBError &error, SBThread &thread) {
+  LLDB_INSTRUMENT_VA(this);
+  if (!m_opaque_sp || !thread.get()) {
----------------
There should be a newline after `LLDB_INSTRUMENT_VA` to match the output of `lldb-instr`. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130930/new/

https://reviews.llvm.org/D130930