[Lldb-commits] [PATCH] D130924: [trace][intelpt] Update TraceIntelPTBundleSaver.cpp to accommodate FileSpec API changes
Jakob Johnson via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Mon Aug 1 11:47:39 PDT 2022
jj10306 created this revision.
jj10306 added reviewers: clayborg, wallace, persona0220.
Herald added a project: All.
jj10306 requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.
D130309 <https://reviews.llvm.org/D130309> introduced changes to the FileSpec API which broke usages of
`GetCString()` in TraceIntelPTBundleSaver.cpp. This diff replaces usages
of `GetCString()` with `GetPath().c_str()` as suggested by D130309 <https://reviews.llvm.org/D130309>.
Test Plan:
Building with the trace plug-in now succeeds
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D130924
Files:
lldb/source/Plugins/Trace/intel-pt/TraceIntelPTBundleSaver.cpp
Index: lldb/source/Plugins/Trace/intel-pt/TraceIntelPTBundleSaver.cpp
===================================================================
--- lldb/source/Plugins/Trace/intel-pt/TraceIntelPTBundleSaver.cpp
+++ lldb/source/Plugins/Trace/intel-pt/TraceIntelPTBundleSaver.cpp
@@ -103,7 +103,7 @@
FileSpec threads_dir = directory;
threads_dir.AppendPathComponent("threads");
- sys::fs::create_directories(threads_dir.GetCString());
+ sys::fs::create_directories(threads_dir.GetPath().c_str());
for (ThreadSP thread_sp : process.Threads()) {
lldb::tid_t tid = thread_sp->GetID();
@@ -200,7 +200,7 @@
std::vector<JSONCpu> json_cpus;
FileSpec cpus_dir = directory;
cpus_dir.AppendPathComponent("cpus");
- sys::fs::create_directories(cpus_dir.GetCString());
+ sys::fs::create_directories(cpus_dir.GetPath().c_str());
for (lldb::cpu_id_t cpu_id : trace_ipt.GetTracedCpus()) {
JSONCpu json_cpu;
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D130924.449086.patch
Type: text/x-patch
Size: 925 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20220801/57cacbf8/attachment-0001.bin>
More information about the lldb-commits
mailing list