[Lldb-commits] [PATCH] D130796: [LLDB][NativePDB] Switch to use DWARFLocationList.

[Zequan Wu via Phabricator via lldb-commits]

zequanwu added a comment.

> If you find yourself needing to do extra work to work its limitations, we should fix that algorithm instead.

That makes sense. I'll work on fixing `RangeVectorData`.



================
Comment at: lldb/source/Expression/DWARFExpressionList.cpp:37-39
+  if (m_exprs.FindEntryThatContains(base) ||
+      m_exprs.FindEntryThatContains(end - 1))
+    return false;
----------------
labath wrote:
> What is this attempting to check? That the list does not contain an overlapping entry? That hardly seems like a correct algorithm...
`RangeDataVector::Append` just append the new entry to the end of vector. It has no idea if overlaps happens or not. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130796/new/

https://reviews.llvm.org/D130796