[Lldb-commits] [PATCH] D129682: [lldb] Filter DIEs based on qualified name when possible

[Pavel Labath via Phabricator via lldb-commits]

labath added a comment.

I like how you've extracted the name construction functionality. Just one (inline) comment about the filtering.



================
Comment at: lldb/source/Core/Module.cpp:740
+  bool user_provided_name_is_mangled =
+      Mangled::GetManglingScheme(m_name.GetStringRef()) !=
+      Mangled::eManglingSchemeNone;
----------------
I think this is overly aggressive. `_Z3foov` could be a method name in some particularly sadistic class. I think you can do this optimization only in one direction: if the names match, then return true without consulting the language plugin. At that point, I don't think you even need to check whether the names are mangled.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129682/new/

https://reviews.llvm.org/D129682