[Lldb-commits] [PATCH] D126614: [lldb] [gdb-remote] Client support for using the non-stop protocol

Michał Górny via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Fri Jul 29 13:25:38 PDT 2022


mgorny updated this revision to Diff 448707.
mgorny marked an inline comment as done.
mgorny added a comment.

Thanks for the suggestions. I have to admit I don't necessarily like the `InterruptRead()` approach but given that the alternative involves major changes to how we read packets, I suppose it's a good enough solution (and big thanks for that suggestion!). All should be done now.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126614/new/

https://reviews.llvm.org/D126614

Files:
  lldb/packages/Python/lldbsuite/test/gdbclientutils.py
  lldb/source/Plugins/Process/gdb-remote/GDBRemoteClientBase.cpp
  lldb/source/Plugins/Process/gdb-remote/GDBRemoteClientBase.h
  lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunication.cpp
  lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunication.h
  lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp
  lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.h
  lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
  lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.h
  lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemoteProperties.td
  lldb/test/API/functionalities/gdb_remote_client/TestNonStop.py

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D126614.448707.patch
Type: text/x-patch
Size: 29666 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20220729/4dd9fcee/attachment-0001.bin>


More information about the lldb-commits mailing list