[Lldb-commits] [PATCH] D130660: [LLDB] Fix missing return value in SBBreakpointLocation::GetQueueName()

[Jim Ingham via lldb-commits]

So far as I can tell, we don't have any significant tests for the "queue specific breakpoint or breakpoint location" feature.  There's a pretty extensive test for identifying queues & getting more detail from them in test/API/macosx/queues/TestQueues.py, but it doesn't test the breakpoint feature.

Both SetQueueName and GetQueueName are called in the api/default_constructor test, but those tests don't assert anything about values, since they are on default-constructed objects.  We also test that we can set a queue name on a breakpoint, serialize the breakpoint, deserialize it and get the queue name back out.  But we can't reuse that for locations since we don't serialize breakpoint locations.

SBBreakpointLocation.{Get,Set}QueueName can be applied to any breakpoint, it doesn't require any queue support from the underlying OS.  Get just gets back whatever string Set put in.  So for coverage of this bug it should be enough to find some test that makes a breakpoint, then set a queue, make sure you get it back again.  

But we really should add some tests that show this actually works.

Jim


> On Jul 27, 2022, at 1:15 PM, Greg Clayton via Phabricator via lldb-commits <lldb-commits at lists.llvm.org> wrote:
> 
> clayborg added a comment.
> 
> There must be a test for this, obviously we don't have one, but check the blame log and ask the original author how this should be tested.
> 
> 
> Repository:
>  rG LLVM Github Monorepo
> 
> CHANGES SINCE LAST ACTION
>  https://reviews.llvm.org/D130660/new/
> 
> https://reviews.llvm.org/D130660
> 
> _______________________________________________
> lldb-commits mailing list
> lldb-commits at lists.llvm.org
> https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits