[Lldb-commits] [PATCH] D130341: [lldb] [gdb-remote] Use vKill packet if multiprocess & available

[Michał Górny via Phabricator via lldb-commits]

mgorny added inline comments.


================
Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp:4268
+    if (response.IsOKResponse())
+      return SIGKILL;
+
----------------
labath wrote:
> This is a host signal number (and not really available on windows). Maybe we should just return zero or indicate that we don't know the "cause of death" in some other way? (Are we sure that there's no way to determine the cause of death?)
Either way's fine with me, I was treating it as pretty much "an arbitrary return value". The way I understand the protocol, we're supposed to assume that if `vKill` succeeded, then the process died because of our kill, and the client isn't really supposed to be interested in the technical details of how it died. FWICS if we issue a `?` to gdbserver after a `vKill`, it returns `W00` (also, it doesn't return it in non-stop mode at all).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130341/new/

https://reviews.llvm.org/D130341