[Lldb-commits] [PATCH] D130540: [lldb] Read from the Rosetta shared cache with Xcode 14

[Jonas Devlieghere via Phabricator via lldb-commits]

JDevlieghere marked an inline comment as done.
JDevlieghere added subscribers: adrian, ismail.
JDevlieghere added inline comments.


================
Comment at: lldb/test/API/macosx/rosetta/TestRosetta.py:7-10
+def apple_silicon(test):
+    return platform.system() == 'Darwin' and test.getArchitecture() in [
+        'arm64', 'arm64e'
+    ]
----------------
aprantl wrote:
> mib wrote:
> > Why not add this to `decorators.py` ?
> FWIW, there's a `skipIfRosetta` decorator there already.
@Adrian: That's not the same thing, that's when the test suite as a whole is run under rosetta.
@Ismail: I thought it was too specific and only used for one test, but I think it makes sense to move it there.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130540/new/

https://reviews.llvm.org/D130540