[Lldb-commits] [PATCH] D130580: Refactor string conversion for InstructionControlFlowKind enum

[Sujin Park via Phabricator via lldb-commits]

persona0220 accepted this revision.
persona0220 added inline comments.
This revision is now accepted and ready to land.


================
Comment at: lldb/source/Core/Disassembler.cpp:930
+  }
+}
+
----------------
jj10306 wrote:
> Thoughts on adding a default case with a string that indicates that no string conversion was implemented for the provided variant?
> This would potentially make it easier for someone to realize they didn't add a case here for a newly added variant of InstructionControlFlowKind. Otherwise undefined data would be returned if a new case isn't added for a new variant.
> wdyt?
I agree to add a default here! 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130580/new/

https://reviews.llvm.org/D130580