[Lldb-commits] [lldb] e80dbfd - [LLDB][Reliability] Fix register value unpacking
Slava Gurevich via lldb-commits
lldb-commits at lists.llvm.org
Tue Jul 26 00:22:55 PDT 2022
Author: Slava Gurevich
Date: 2022-07-26T00:22:40-07:00
New Revision: e80dbfddc5aa567aea0a974708af4122c2b49829
URL: https://github.com/llvm/llvm-project/commit/e80dbfddc5aa567aea0a974708af4122c2b49829
DIFF: https://github.com/llvm/llvm-project/commit/e80dbfddc5aa567aea0a974708af4122c2b49829.diff
LOG: [LLDB][Reliability] Fix register value unpacking
Fix incorrect direction for bit-shifting.
Coverity warning 1355603 (scan.coverity.com)
Differential Revision: https://reviews.llvm.org/D130307
Added:
Modified:
lldb/source/Plugins/Instruction/ARM/EmulationStateARM.cpp
Removed:
################################################################################
diff --git a/lldb/source/Plugins/Instruction/ARM/EmulationStateARM.cpp b/lldb/source/Plugins/Instruction/ARM/EmulationStateARM.cpp
index 569482c7b23b1..32430cd96d15a 100644
--- a/lldb/source/Plugins/Instruction/ARM/EmulationStateARM.cpp
+++ b/lldb/source/Plugins/Instruction/ARM/EmulationStateARM.cpp
@@ -97,7 +97,7 @@ uint64_t EmulationStateARM::ReadPseudoRegisterValue(uint32_t reg_num,
uint32_t idx = reg_num - dwarf_d0;
if (idx < 16)
value = (uint64_t)m_vfp_regs.s_regs[idx * 2] |
- ((uint64_t)m_vfp_regs.s_regs[idx * 2 + 1] >> 32);
+ ((uint64_t)m_vfp_regs.s_regs[idx * 2 + 1] << 32);
else
value = m_vfp_regs.d_regs[idx - 16];
} else
More information about the lldb-commits
mailing list