[Lldb-commits] [PATCH] D130401: Implement better path matching in FileSpecList::FindCompatibleIndex(...).

Greg Clayton via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Jul 25 16:54:51 PDT 2022


clayborg updated this revision to Diff 447523.
clayborg added a comment.

- Added windows tests to make sure FileSpecList::FindCompatibleIndex() works on windows
- Use lambdas to simplify code in FileSpecList::FindCompatibleIndex()
- Remove the "full" argument from FindCompatibleIndex
- Reword the comment that explains when we will use a filename match only.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130401/new/

https://reviews.llvm.org/D130401

Files:
  lldb/include/lldb/Breakpoint/BreakpointResolverFileLine.h
  lldb/include/lldb/Core/FileSpecList.h
  lldb/include/lldb/Utility/FileSpec.h
  lldb/source/Breakpoint/BreakpointResolverFileLine.cpp
  lldb/source/Core/FileSpecList.cpp
  lldb/source/Symbol/CompileUnit.cpp
  lldb/source/Utility/FileSpec.cpp
  lldb/test/API/functionalities/breakpoint/breakpoint_command/TestBreakpointCommand.py
  lldb/test/API/functionalities/breakpoint/breakpoint_command/relative.yaml
  lldb/unittests/Core/CMakeLists.txt
  lldb/unittests/Core/FileSpecListTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D130401.447523.patch
Type: text/x-patch
Size: 38224 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20220725/a9afdfac/attachment-0001.bin>


More information about the lldb-commits mailing list