[Lldb-commits] [PATCH] D130307: [LLDB][Reliability] Fix register value unpacking

[David Spickett via Phabricator via lldb-commits]

DavidSpickett added a comment.

So I looked into what *should* be testing this and if it was done comprehensively it would have been testing it. However the Arm emulation tests:

- Don't check D registers directly, only S (which is why we didn't miss the upper 32 bits).
- Don't verify that memory expected matches memory got (memory is mostly used as an input to registers).
- Don't specify the final state of memory anyway.

I got some way into fixing that and found ~50 tests that use memory but don't verify the content.

Which is to say, yes this can and should have been tested :)

I will put up some patches shortly to build on this and maybe make the memory checking optional. Then this can be tested, and I'll work towards adding memory checks to the other tests over time.

So hold off on landing while I come up with that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130307/new/

https://reviews.llvm.org/D130307