[Lldb-commits] [PATCH] D129682: [lldb] Filter DIEs based on qualified name when possible

[Jim Ingham via Phabricator via lldb-commits]

jingham added a comment.

It always bugged me that `break set some::long::path::a_common_word` was going to realize all the debug info for functions called "a_common_word".  In large projects there can be a lot of those.  So I'm not 100% surprised that this gives us a good speedup (but happy!)

I certainly don't want us to give up on setting breakpoints by overload as well as function name.  This is currently inconvenient because we don't have a "fuzzy argument matcher", instead you have to type the arguments exactly as the demangler would.  That shouldn't be all that hard to implement, and even without that it's a fairly useful feature when you've got lots of overloads.  The alternative, setting the breakpoint on the name and then disabling the overloads you don't want, is tedious and makes us look a little weak...

I'm not familiar enough with the DWARF parser to make useful comments on that part of the change, but the rest looks fine, and this is a great idea.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129682/new/

https://reviews.llvm.org/D129682