[Lldb-commits] [PATCH] D129814: Fix stepping over watchpoints in architectures that raise the exception before executing the instruction

[Jim Ingham via Phabricator via lldb-commits]

jingham added a comment.

Ack, bad memory.  It was actually originally done in PerformAction, but that has the same effect.  You really shouldn't run the target in PerformAction if you can manage it.  That's why, for instance, I added a --auto-continue flag to the breakpoints (probably should do the same for watchpoints) so that the thread list code gets a chance to reason about the state before continuing.  We do run expressions there, but we should really only do that if (a) we know the expression will only run the current thread or (b) we're doing it for the user, where if they have an expression that requires all threads to run, they needed to do that and presumably were willing to trade off running the expression for changing the state of the other threads from what it was at the initial stop.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129814/new/

https://reviews.llvm.org/D129814