[Lldb-commits] [PATCH] D129736: [lldb] Skip a float16 NaN test for RISC-V

[David Spickett via Phabricator via lldb-commits]

DavidSpickett added a comment.

Seems fine to me. Do you have a tracking issue for this? You could just open one for "lldb riscv test failures" and add comments as you find more failures. So people can see the current state of the test suite.



================
Comment at: lldb/unittests/Core/DumpDataExtractorTest.cpp:202
 
+#if !defined(__riscv)
   // quiet/signaling NaNs.
----------------
Add a brief comment with the reason, "riscv does not support...." just a one liner.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129736/new/

https://reviews.llvm.org/D129736