[Lldb-commits] [PATCH] D129239: [trace] Add an option to save a compact trace bundle

[walter erquinigo via Phabricator via lldb-commits]

wallace added inline comments.


================
Comment at: lldb/source/Plugins/Trace/intel-pt/PerfContextSwitchDecoder.cpp:318
+        should_copy = true;
+    } else if (perf_record.IsErrorRecord()) {
+      should_copy = true;
----------------
jj10306 wrote:
> why do we want the error record?
i don't want to lose this information because they can show contention issues


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129239/new/

https://reviews.llvm.org/D129239