[Lldb-commits] [PATCH] D129078: [LLDB][ClangExpression] Allow expression evaluation from within C++ Lambdas

[Jim Ingham via Phabricator via lldb-commits]

jingham accepted this revision.
jingham added a comment.

One trivial naming tweak, otherwise this looks good.



================
Comment at: lldb/source/Plugins/ExpressionParser/Clang/ClangExpressionUtil.cpp:20
+
+  if (auto thisValSP = frame->FindVariable(ConstString("this")))
+    if (thisValSP->GetChildMemberWithName(ConstString("this"), true))
----------------
lldb generally uses "this_val_sp" form for local variables.  Camel case is for method names, initial lower camel case for llvm method names. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129078/new/

https://reviews.llvm.org/D129078