[Lldb-commits] [PATCH] D129603: [lldb/crashlog] Fix interactive crashlog test

Jonas Devlieghere via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed Jul 13 09:49:33 PDT 2022


JDevlieghere added a comment.

- Do we need the source file for anything? I think it's fine to keep it around to regenerate the test, but please fix the extension. Nothing in lldb uses `.cc`.
- I think if we check in the "binary", we should also update the other crashlogs tests to rely on it, and get rid of `patch-crashlog.py`.
- Let's format the JSON so it's more readable and easier to write tests for it in the future.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129603/new/

https://reviews.llvm.org/D129603



More information about the lldb-commits mailing list