[Lldb-commits] [PATCH] D129613: [trace][intel pt] Add a nice parser for the trace size

[Jakob Johnson via Phabricator via lldb-commits]

jj10306 accepted this revision.
jj10306 added inline comments.
This revision is now accepted and ready to land.


================
Comment at: lldb/source/Plugins/Trace/intel-pt/CommandObjectTraceStartIntelPT.cpp:174
+
+  std::map<std::string, uint64_t> multipliers = {{"mib", 1024 * 1024},
+                                                 {"mb", 1024 * 1024},
----------------
nit


================
Comment at: lldb/source/Plugins/Trace/intel-pt/CommandObjectTraceStartIntelPT.cpp:175-181
+                                                 {"mb", 1024 * 1024},
+                                                 {"m", 1024 * 1024},
+                                                 {"kib", 1024},
+                                                 {"kb", 1024},
+                                                 {"k", 1024},
+                                                 {"b", 1},
+                                                 {"", 1}};
----------------
nit: this may be overkill but consider using constants here


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129613/new/

https://reviews.llvm.org/D129613