[Lldb-commits] [PATCH] D129239: [trace] Add an option to save a compact trace bundle

Jonas Devlieghere via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed Jul 13 08:49:11 PDT 2022


JDevlieghere added inline comments.


================
Comment at: lldb/source/Commands/CommandObjectProcess.cpp:582
       }
-      
+
       Target *target = m_exe_ctx.GetTargetPtr();
----------------
wallace wrote:
> many formatting changes sneaked in. The actual changes are in the end of this file
Please separate the formatting changes into a separate patch/commit. That way they're much easier to identify in the git blame output instead of getting attributed to an unrelated change. What I usually do in this scenario is format the file, commit than, and then rebase my change on top. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129239/new/

https://reviews.llvm.org/D129239



More information about the lldb-commits mailing list