[Lldb-commits] [PATCH] D129613: [trace][intel pt] Add a nice parser for the trace size

[walter erquinigo via Phabricator via lldb-commits]

wallace created this revision.
wallace added reviewers: persona0220, jj10306.
Herald added a project: All.
wallace requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.

Thanks to rnofenko at fb.com for coming up with these changes.

This diff adds support for passing units in the trace size inputs. For example,
it's now possible to specify 64KB as the trace size, instead of the
problematic 65536. This makes the user experience a bit friendlier.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D129613

Files:
  lldb/source/Plugins/Trace/intel-pt/CommandObjectTraceStartIntelPT.cpp
  lldb/source/Plugins/Trace/intel-pt/CommandObjectTraceStartIntelPT.h
  lldb/source/Plugins/Trace/intel-pt/TraceIntelPT.cpp
  lldb/source/Plugins/Trace/intel-pt/TraceIntelPTOptions.td
  lldb/test/API/commands/trace/TestTraceStartStop.py

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D129613.444130.patch
Type: text/x-patch
Size: 10811 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20220713/03cf5270/attachment-0001.bin>