[Lldb-commits] [PATCH] D128465: [llvm] cmake config groundwork to have ZSTD in LLVM and add ZSTD compression namespace

Tue Jul 12 12:35:35 PDT 2022

MaskRay added a comment.

In D128465#3646203 <https://reviews.llvm.org/D128465#3646203>, @ckissane wrote:

> In D128465#3642997 <https://reviews.llvm.org/D128465#3642997>, @MaskRay wrote:
>
>> As I mentioned, the proper approach is to add zstd functionality along with the CMake change, instead of adding CMake to all llvm-project components without a way to test them.
>
> @MaskRay, I have now done this and ran the ldd tests as requested:
>
>   With LLVM_ENABLE_ZSTD=ON
>   $ ninja check-lld
>   Testing Time: 8.98s
>     Unsupported      :   17
>     Passed           : 2638
>     Expectedly Failed:    1
>   With LLVM_ENABLE_ZSTD=OFF
>   $ ninja check-lld
>   Testing Time: 8.95s
>     Unsupported      :   17
>     Passed           : 2638
>     Expectedly Failed:    1

I request that you abandon this patch and incorporate the llvm cmake part into the llvm patch which you actually use zstd.
It is not appropriate to add zstd cmake to llvm-project components which don't use zstd.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128465/new/

https://reviews.llvm.org/D128465