[Lldb-commits] [PATCH] D129528: Modify all register values whose byte size matches the address size to be formatter as eFormatAddressInfo.

[Jonas Devlieghere via Phabricator via lldb-commits]

JDevlieghere added inline comments.


================
Comment at: lldb/test/API/tools/lldb-vscode/variables/TestVSCode_variables.py:493-498
+        if arch == 'x86_64':
+            pc_name = 'rip'
+        elif arch == 'x86':
+            pc_name = 'rip'
+        elif arch.startswith('arm'):
+            pc_name = 'pc'
----------------



================
Comment at: lldb/tools/lldb-vscode/lldb-vscode.cpp:1939
+  // pointer resolves to.
+  uint32_t addr_size = frame.GetThread().GetProcess().GetAddressByteSize();
+  const uint32_t num_reg_sets = g_vsc.variables.registers.GetSize();
----------------
yinghuitan wrote:
> The change looks good. But I do not think we should pay this cost during each stop. Can we only call this when user expands "registers" scope? 
I'd make this const too, like `num_reg_sets`, otherwise it looks like this is meant to change.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129528/new/

https://reviews.llvm.org/D129528