[Lldb-commits] [PATCH] D129521: Add the ability to run expressions that call fork() or vfork().

[jeffrey tan via Phabricator via lldb-commits]

yinghuitan added a comment.

Change looks good to me. I will let @jingham take a second look before accepting.

I do wonder if there will be more unexpected signals (like SIGCHILD, SIGPIPE etc...) causing expression evaluation to pause? Should we maybe default to not stop on signals?



================
Comment at: lldb/source/Target/ThreadPlanCallFunction.cpp:380
   Thread &thread = GetThread();
-  m_subplan_sp = std::make_shared<ThreadPlanRunToAddress>(thread, m_start_addr, 
+  m_subplan_sp = std::make_shared<ThreadPlanRunToAddress>(thread, m_start_addr,
                                                           m_stop_other_threads);
----------------
Undo this accidental change?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129521/new/

https://reviews.llvm.org/D129521