[Lldb-commits] [PATCH] D129529: [lldb] Make the g_arguments_data constexpr and fix the static assert

[Jim Ingham via Phabricator via lldb-commits]

jingham added a comment.

Ack, sorry I missed adding that one!

Everything else looks fine, but you parsed the enum incorrectly, it's eArgType - RecognizerID.  This is in fact a stack-frame recognizer ID.  I suggested an appropriate version above.



================
Comment at: lldb/source/Interpreter/CommandObject.cpp:1137
     { eArgTypeSEDStylePair, "substitution-pair", CommandCompletions::eNoCompletion, { nullptr, false }, "A sed-style pattern and target pair." },
+    { eArgTypeRecognizerID, "type-recognizer-id", CommandCompletions::eNoCompletion, { nullptr, false }, "A type recongizer identifier." },
     { eArgTypeConnectURL, "process-connect-url", CommandCompletions::eNoCompletion, { nullptr, false }, "A URL-style specification for a remote connection." },
----------------



CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129529/new/

https://reviews.llvm.org/D129529